Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing api sample docs #9869

Merged
merged 14 commits into from
Mar 13, 2024
Merged

docs: add missing api sample docs #9869

merged 14 commits into from
Mar 13, 2024

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@yoonhyejin yoonhyejin requested a review from hsheth2 February 16, 2024 06:59
@github-actions github-actions bot added the docs Issues and Improvements to docs label Feb 16, 2024
@yoonhyejin yoonhyejin marked this pull request as ready for review February 16, 2024 14:12
@yoonhyejin
Copy link
Collaborator Author

@hsheth2 could you force-merge on this? not really sure why vercel fails without errors, yarn build works fine locally

@hsheth2
Copy link
Collaborator

hsheth2 commented Feb 20, 2024

@yoonhyejin given that the vercel build has failed consistently, I don't feel great about force merging it.

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Feb 20, 2024
@hsheth2
Copy link
Collaborator

hsheth2 commented Mar 12, 2024

@yoonhyejin feels like there's a formatting issue here - can you try reproducing locally?

@hsheth2 hsheth2 merged commit 729090b into master Mar 13, 2024
34 of 35 checks passed
@hsheth2 hsheth2 deleted the docs/add-api-examples branch March 13, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants