feat(policies): Make policies searchable by privilege, type, status or editable fields #9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r editable fields
github-actions
bot
added
the
devops
pedro93
changed the title
anshbansal
reviewed
Feb 19, 2024
...ade/src/main/java/com/linkedin/datahub/upgrade/system/entity/steps/BackfillPolicyFields.java
Outdated
Show resolved
Hide resolved
anshbansal
reviewed
Feb 19, 2024
...src/main/java/com/linkedin/datahub/upgrade/system/entity/steps/BackfillPolicyFieldsStep.java
Outdated
Show resolved
Hide resolved
anshbansal
reviewed
Feb 19, 2024
| @Searchable = { | ||
| "/*": { | ||
| "fieldType": "KEYWORD", | ||
| "addToFilters": true |
There was a problem hiding this comment.
What doesaddToFilters allow us to do?
There was a problem hiding this comment.
See https://datahubproject.io/docs/next/metadata-modeling/extending-the-metadata-model/#searchable - This is to allow the array values to be used as filters from what I understand.
anshbansal
reviewed
Feb 19, 2024
...src/main/java/com/linkedin/datahub/upgrade/system/entity/steps/BackfillPolicyFieldsStep.java
Outdated
Show resolved
Hide resolved
pedro93
changed the title
pedro93
changed the title
...l-core/src/main/java/com/linkedin/datahub/graphql/resolvers/policy/ListPoliciesResolver.java
Outdated
Show resolved
Hide resolved
...l-core/src/main/java/com/linkedin/datahub/graphql/resolvers/policy/ListPoliciesResolver.java
Outdated
Show resolved
Hide resolved
RyanHolstien
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds searchable annotations to DataHubPolicyInfo fields:
privilege,type,statusandeditablefields so that we can use these fields for filtering in graphQL queries + a filter parameter when listing policies.For backfilling pre-existing policies, adds a system update step to RESTATE existing policies. This is enabled by default so the mae processor updates documents in ES for all pre-existing DataHub policies.
Tested it works by checking elasticsearch directly to see new properties are available:
And that using the graphQL command I am able to filter by the new features:
Checklist