Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/unity-catalog): generate sibling and lineage #9894

Merged
merged 11 commits into from
Mar 18, 2024
Merged

fix(ingest/unity-catalog): generate sibling and lineage #9894

merged 11 commits into from
Mar 18, 2024

Conversation

dushayntAW
Copy link
Contributor

generate siblings and linage in case of external delta table

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Feb 21, 2024
@mayurinehate mayurinehate self-requested a review February 22, 2024 10:33
@asikowitz asikowitz removed the community-contribution PR or Issue raised by member(s) of DataHub Community label Feb 22, 2024
@dushayntAW dushayntAW marked this pull request as ready for review February 23, 2024 06:58
@anshbansal anshbansal changed the title fix(ingest/unity-catalog): generate sibling and linage fix(ingest/unity-catalog): generate sibling and lineage Feb 26, 2024
mayurinehate
mayurinehate reviewed Mar 13, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/unity/config.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/unity/config.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/unity/source.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/unity/source.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/unity/source.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/integration/unity/test_unity_catalog_ingest.py Outdated Show resolved Hide resolved
metadata-ingestion/docs/sources/databricks/unity-catalog_recipe.yml Outdated Show resolved Hide resolved
metadata-ingestion/docs/sources/databricks/unity-catalog_recipe.yml Outdated Show resolved Hide resolved
metadata-ingestion/tests/integration/unity/test_unity_catalog_ingest.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/integration/unity/unity_catalog_mces_golden.json Outdated Show resolved Hide resolved
mayurinehate
mayurinehate approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment.

metadata-ingestion/src/datahub/ingestion/source/unity/config.py Outdated Show resolved Hide resolved
@anshbansal anshbansal merged commit 3a4bdef into datahub-project:master Mar 18, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

@anshbansal anshbansal anshbansal approved these changes

Assignees

@mayurinehate mayurinehate

Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dushayntAW @anshbansal @mayurinehate @asikowitz