Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): enable stateful_ingestion by default for DataHub rest sink #9934

Merged
merged 8 commits into from
Mar 5, 2024
Merged

feat(ingest): enable stateful_ingestion by default for DataHub rest sink #9934

merged 8 commits into from
Mar 5, 2024

Conversation

shubhamjagtap639
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Feb 27, 2024
@shubhamjagtap639 shubhamjagtap639 marked this pull request as ready for review February 29, 2024 11:02
@RyanHolstien RyanHolstien requested a review from hsheth2 February 29, 2024 18:23
hsheth2
hsheth2 reviewed Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to update docs/how/updating-datahub.md

metadata-ingestion/src/datahub/ingestion/source/state/stateful_ingestion_base.py Outdated Show resolved Hide resolved
metadata-ingestion/tests/unit/stateful_ingestion/provider/test_provider.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/state/stateful_ingestion_base.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 changed the title feat(stateful-ingestion): enable stateful_ingestion by default for DataHub rest sink feat(ingest): enable stateful_ingestion by default for DataHub rest sink Mar 4, 2024
@hsheth2 hsheth2 merged commit fda5eb8 into datahub-project:master Mar 5, 2024
53 checks passed
dushayntAW pushed a commit to dushayntAW/datahub that referenced this pull request Mar 7, 2024
@shubhamjagtap639 @dushayntAW
feat(ingest): enable stateful_ingestion by default for DataHub rest s…
f316c92 
…ink (datahub-project#9934)
@shubhamjagtap639 shubhamjagtap639 deleted the Enable-stateful_ingestion-by-default branch March 14, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamjagtap639 @hsheth2 @RyanHolstien