Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): sort partition keys to the top of the table for better visibility #9959

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat(ui): sort partition keys to the top of the table for better visibility #9959

merged 1 commit into from
Mar 27, 2024

Conversation

ngamanda
Copy link
Contributor

@ngamanda ngamanda commented Feb 29, 2024 •
edited
Loading

Move partition keys to the top of the schema table so that users can easily see all available partition keys on the table at first glance.

(Love the move to Vite folks! ❤️ )

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions labels Feb 29, 2024
chriscollins3456
chriscollins3456 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me!

@jjoyce0510 jjoyce0510 merged commit 95a444a into datahub-project:master Mar 27, 2024
37 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@ngamanda @sleeperdeep
feat(ui): sort partition keys to the top of the table for better visi…
9fd1d64 
…bility (datahub-project#9959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees

@chriscollins3456 chriscollins3456

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngamanda @chriscollins3456 @jjoyce0510