Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): throw codegen error on duplicate class names #9960

Merged
merged 1 commit into from
Mar 1, 2024
Merged

feat(ingest): throw codegen error on duplicate class names #9960

merged 1 commit into from
Mar 1, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 29, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 29, 2024
@hsheth2 hsheth2 requested a review from treff7es February 29, 2024 18:50
@hsheth2 hsheth2 merged commit 4c83f10 into master Mar 1, 2024
52 of 53 checks passed
@hsheth2 hsheth2 deleted the codegen-name-protection branch March 1, 2024 00:13
alexs-101 pushed a commit to alexs-101/datahub that referenced this pull request Mar 1, 2024
@hsheth2
feat(ingest): throw codegen error on duplicate class names (datahub-p…
4aa1dc3 
…roject#9960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es