Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/dbt): dbt model performance #9992

Merged
merged 25 commits into from
Mar 27, 2024
Merged

feat(ingest/dbt): dbt model performance #9992

merged 25 commits into from
Mar 27, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 6, 2024 •
edited
Loading

Model changes:

  • Allows dataProcessInstances to be directly associated with datasets
  • Adds a duration field to data process run events

Ingestion

  • Add support for reading multiple run_result.json files
  • Ingest model build performance metadata
  • Deprecate test_results_file in favor of run_results_files

Frontend

  • Rename dataset "Operations" tab to "Runs"
  • Display a duration column
  • Hide certain columns when only datasets live in "Runs"
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Mar 6, 2024
@hsheth2 hsheth2 mentioned this pull request Mar 11, 2024
Merged
5 tasks
@hsheth2 hsheth2 changed the title feat(ingest/dbt): dbt model performance + view improvements feat(ingest/dbt): dbt model performance Mar 11, 2024
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Mar 11, 2024

Moved the compiled code changes to #10026

@hsheth2 hsheth2 marked this pull request as ready for review March 11, 2024 22:46
asikowitz
asikowitz approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't give a proper review to this but don't want to be a blocker

@asikowitz
Copy link
Collaborator

Looks like there's some type errors

@hsheth2 hsheth2 merged commit f0bdc24 into master Mar 27, 2024
63 of 64 checks passed
@hsheth2 hsheth2 deleted the dbt-v2 branch March 27, 2024 00:18
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@hsheth2 @sleeperdeep
feat(ingest/dbt): dbt model performance (datahub-project#9992)
b5db302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz