add np.datetime64 serialization and tests #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Alright I have moved the datetime64 array serialization to use the scalar mapping dictionary instead of the object mapping dictionary, this solution should be complete now @dimitri-yatsenko. I have some extra time so I will work on refactoring the naming like we discussed. |
|
Seems like datetime64 is no longer experimental, see this github thread. I think we are good to go ahead and merge @guzman-raphael |
guzman-raphael
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
@jverswijver Fantastic work! 💪
That is an awesome performance boost! 1000x
🏁 🏎️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1019
I have added the ability to serialize
numpy.datetime64types into datajoint. This pr includes a pack/unpack test as well as a test that checks to see if serializing/deserializingnumpy.datetime64is still faster than regular datetime.fix #1022
fix #1035