-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix readability of tutorials in dark mode #1080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushalbakshi Thanks for patching this! 💪
Dark mode users (:raising_hand_man:) will certainly appreciate this improvement. Providing some small suggestions but otherwise agree with the approach here.
Co-authored-by: Raphael Guzman <[email protected]>
Hi @guzman-raphael, I'm finally getting the chance to get back on this one. Here is one example each of black background with white text, and black text with white background. Let me know what you prefer. I think the black background is cleaner in dark mode, but it's up to you. |
Thanks @kushalbakshi. That is an interesting option. 🤔 Just discussed this with @kabilar to get his opinion and he agreed with me that the white background one is cleaner. Let's proceed with that. |
Sounds good! The changes have been tested and committed here. Something to note - the docs container would not build without the
|
Commenting to record that I was able to remove the |
This PR fixes the readability of the Jupyter Notebook outputs in the
Using the json type
tutorials. This resolves issue 1078.Below are the screenshots from local testing after applying changes to the code as seen in this PR:
Dark mode - the font in the tables previously appeared white, and was therefore, not readable. See linked issue above for images.
Light mode - there was no issue here previously and remains the same as before.