Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set_password to work on MySQL 8 #1106

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Sep 2, 2023

Fix #1104

  • Updated set_password to work on MySQL 8
  • Added missing tests for set_password (not sure how to test different MySQL versions though)
  • Updated logger.warn -> logger.warning because logger.warn is deprecated

Copy link
Member

@dimitri-yatsenko dimitri-yatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you!

@lfrank
Copy link

lfrank commented Sep 18, 2023

@dimitri-yatsenko Just wanted to check in on this; we're hoping that this might be fixed before we submit the spyglass paper. Thoughts?

@dimitri-yatsenko
Copy link
Member

The implementation looks good but we need to check why tests failed.

@dimitri-yatsenko
Copy link
Member

Also, we need to update the README.

@rly
Copy link
Contributor Author

rly commented Sep 19, 2023

The old test suite failed due to the error: Max retries exceeded with url: /datajoint.test (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1129)')))

I wonder whether my fork does not have the right permissions, certificates, or some other setting to access the test database. Or perhaps it was a one-time fluke as the github actions images were being updated with new certificates?

Details ``` app_1 | ====================================================================== app_1 | ERROR: test suite for app_1 | ---------------------------------------------------------------------- app_1 | Traceback (most recent call last): app_1 | File "/home/anaconda/.local/lib/python3.9/site-packages/nose/suite.py", line 210, in run app_1 | self.setUp() app_1 | File "/home/anaconda/.local/lib/python3.9/site-packages/nose/suite.py", line 293, in setUp app_1 | self.setupContext(ancestor) app_1 | File "/home/anaconda/.local/lib/python3.9/site-packages/nose/suite.py", line 316, in setupContext app_1 | try_run(context, names) app_1 | File "/home/anaconda/.local/lib/python3.9/site-packages/nose/util.py", line 471, in try_run app_1 | return func() app_1 | File "/src/tests_old/__init__.py", line 128, in setup_package app_1 | minioClient.make_bucket(S3_CONN_INFO["bucket"], location=region) app_1 | File "/opt/conda/lib/python3.9/site-packages/minio/api.py", line 618, in make_bucket app_1 | self._url_open( app_1 | File "/opt/conda/lib/python3.9/site-packages/minio/api.py", line 266, in _url_open app_1 | response = self._http.urlopen( app_1 | File "/opt/conda/lib/python3.9/site-packages/urllib3/poolmanager.py", line 376, in urlopen app_1 | response = conn.urlopen(method, u.request_uri, **kw) app_1 | File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 815, in urlopen app_1 | return self.urlopen( app_1 | File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 815, in urlopen app_1 | return self.urlopen( app_1 | File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 815, in urlopen app_1 | return self.urlopen( app_1 | File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 787, in urlopen app_1 | retries = retries.increment( app_1 | File "/opt/conda/lib/python3.9/site-packages/urllib3/util/retry.py", line 592, in increment app_1 | raise MaxRetryError(_pool, url, error or ResponseError(cause)) app_1 | urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='fakeservices.datajoint.io', port=443): Max retries exceeded with url: /datajoint.test (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1129)'))) ```

@dimitri-yatsenko dimitri-yatsenko merged commit 7a61bb7 into datajoint:master Sep 19, 2023
3 of 7 checks passed
@rly rly deleted the fix_change_password branch September 19, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dj.set_password does not work in MySQL 8
3 participants