-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev container #1115
Fix dev container #1115
Conversation
MySQL 8.0 in Docker was ignoring the MYSQL_ROOT_PASSWORD environment variable, setting the default user/pass to root and password. Update the env vars in the dev stack to match these values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The container builds successfully now. The only issue is that it seems to be missing nosetest
and the mysql
CLI dependencies. These are listed as features in the current docs so it's best to include them. Also I'd set DJ_PASS
to simple
to be consistent with the example in the docs.
It's probably a good idea to test all the features mentioned in the docs. Once those work we'll be good to merge.
After changing any of the configuration in the
|
For MySQL 8.0 only (not 5.7), |
If that's the case then it makes sense 👍 |
|
Followed the instructions in https://code.visualstudio.com/docs/devcontainers/create-dev-container to recreate the
.devcontainer
directory and contents from scratch, from theLNX-docker-compose.yml
compose stack as a base. @A-Baji could you test to see if this works for you in VS code?