Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hidden timestamp attribute by default #1188

Merged
merged 7 commits into from
Sep 22, 2024
Merged

Conversation

ethho
Copy link
Contributor

@ethho ethho commented Sep 22, 2024

Adds configuration flag datajoint.config["add_hidden_timestamp"], set to False by default, which toggles automatic addition of the timestamp hidden attribute. Patches #1091, #1180.

@ethho ethho self-assigned this Sep 22, 2024
@ethho
Copy link
Contributor Author

ethho commented Sep 22, 2024

CI runs blocked by either datajoint/nginx-docker#56 or #1183.

Copy link
Member

@dimitri-yatsenko dimitri-yatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the setting name more specific to implicit timestamps.

@ethho ethho marked this pull request as ready for review September 22, 2024 19:14
@ethho ethho changed the title Disable hidden attributes by default Disable hidden timestamp attribute by default Sep 22, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@dimitri-yatsenko dimitri-yatsenko merged commit 3451149 into master Sep 22, 2024
23 checks passed
@dimitri-yatsenko dimitri-yatsenko deleted the patch-1180 branch September 22, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants