Fix regression sql mode #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guzman-raphael
requested changes
Oct 1, 2021
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| * Bugfix - Replace use of numpy aliases of built-in types with built-in type. (#938) PR #939 | |||
| * Bugfix - `ExternalTable.delete` should not remove row on error (#953) PR #956 | |||
| * Bugfix - Fix error handling of remove_object function in `s3.py` (#952) PR #955 | |||
| * Bugfix - Fix sql code generation to comply with sql mode ONLY_FULL_GROUP_BY (#916) PR #965 | |||
There was a problem hiding this comment.
Suggested change
| * Bugfix - Fix sql code generation to comply with sql mode ONLY_FULL_GROUP_BY (#916) PR #965 | |
| * Bugfix - Fix sql code generation to comply with sql mode `ONLY_FULL_GROUP_BY` (#916) PR #965 |
docs-parts/intro/Releases_lang1.rst
Outdated
| @@ -4,6 +4,7 @@ | |||
| * Bugfix - Replace use of numpy aliases of built-in types with built-in type. (#938) PR #939 | |||
| * Bugfix - `ExternalTable.delete` should not remove row on error (#953) PR #956 | |||
| * Bugfix - Fix error handling of remove_object function in `s3.py` (#952) PR #955 | |||
| * Bugfix - Fix sql code generation to comply with sql mode ONLY_FULL_GROUP_BY (#916) PR #965 | |||
There was a problem hiding this comment.
Suggested change
| * Bugfix - Fix sql code generation to comply with sql mode ONLY_FULL_GROUP_BY (#916) PR #965 | |
| * Bugfix - Fix sql code generation to comply with sql mode ``ONLY_FULL_GROUP_BY`` (#916) PR #965 |
|
|
||
|
|
||
| def test_aggr_with_proj(): | ||
| # issue #944 - only breaks with MariaDB |
There was a problem hiding this comment.
@jverswijver Not very clear on this one about the MariaDB breakage noted here. Let tag up on this too to understand more about this fix/test. Also, would be good to give an assert criteria of this test as opposed to simple expecting the query not to 'fail'.
guzman-raphael
approved these changes
Oct 1, 2021
dimitri-yatsenko
approved these changes
Oct 6, 2021
Co-authored-by: Dimitri Yatsenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test for #944
fix #916 and added test