-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise pytesting, update docker, add QC notebook #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- markdownlint: remove trailing spaces - pre-commit-config: remove trailing spaces - requirements_dev: collapse across development/testing requirements - tests/__init__ -> conftest per pytest documentation - tests/*py: remove extra imports - tests/*py: adjust variable names for clarity - workflow/init: migrate db_prefix here to be available to both pipeline and reference - workflow/reference: migrate supplemental tables, Equipment -> device - workflow/ingest: print->logger statements, Equipment -> device, parameterize print str - workflow/pipeline: Loc - pyproject.toml: NEW. gives default params and path to pytest to speed up init
6 tasks
WIP notebooks and jupytext add to precommit Dockerfile - add caiman install populate.py -> process.py to reflect standard elsewhere paths.py - add output typing suggestions conftest pytest fixtures - set default teardown true - add fixture for element helper funcs - add func to loop populate command and parallel teardown func - add fixtures to populate motition correction, segmentation, etc tests_populate - add tests for results (e.g., activity traces) tests_support - add tests for element support funcs
CBroz1
changed the title
Revise pytesting, update docker
Revise pytesting, update docker, add QC notebook
Jan 10, 2023
6 tasks
kushalbakshi
approved these changes
Jan 11, 2023
kushalbakshi
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also element PR
Submission checklist
Files changed
prior to selectingCreate Pull Request
.Submission details
In this pull request, I make the following changes:
populate_table
,populate_clear
)post_curation
get_root_data_dir
)Coverage report
Overall, I improve coverage by ~40%
Missing
Docker
I'm able to install docker if I hop in to the container, but my install scripts time out during docker compose. There are perhaps workarounds, but I leave this to future PRs. Instead, I leave warnings on the topic.