Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Level control resets the local logging level when no events are written in durable mode #78

Closed
nblumhardt opened this issue Jul 26, 2017 · 2 comments
Closed

Level control resets the local logging level when no events are written in durable mode #78

nblumhardt opened this issue Jul 26, 2017 · 2 comments
Labels
bug

Comments

@nblumhardt
Copy link
Member

From #75

The finally block below resets the switch to null when the batch count is zero and no background check is due:

https://github.com/serilog/serilog-sinks-seq/blob/dev/src/Serilog.Sinks.Seq/Sinks/Seq/HttpLogShipper.cs#L226

CC @siabrac
@nblumhardt nblumhardt added the bug label Jul 26, 2017
nblumhardt added a commit to nblumhardt/serilog-sinks-seq that referenced this issue Jul 26, 2017
@nblumhardt
Fixes datalust#78 - when durable, don't reset the switch unless a con…
9a2a8d5 
…nection is actually made
@nblumhardt nblumhardt mentioned this issue Jul 26, 2017
Merged
@nblumhardt nblumhardt mentioned this issue Jul 26, 2017
Merged
@nblumhardt
Copy link
Member Author

Fix in 3.3.4-dev-00126. Looking into one more possible durable/level control interaction, will figure that out and then get a new release published.

@nblumhardt nblumhardt mentioned this issue Jul 27, 2017
Merged
@nblumhardt
Copy link
Member Author

One additional issue fixed in 3.3.4-dev-00129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nblumhardt