Default to nesting (un-flattening) dotted property names #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serilog 4.2 will allow dotted property names in message templates.
For Seq to provide a good querying experience over dotted names, and so that its message template rendering can work consistently with events ingested from this sink and those ingested via OTLP, the sink needs to process dotted names into nested objects prior to them being sent to the ingestion endpoint.
Because a small number of existing apps will already rely on dotted names being transmitted as-is, the PR includes an opt out through
new SeqCompactJsonFormatter(..., preserveDottedNames: true).The included test verifies that the expected processing is applied; the property name processing mechanism is already tested via
UnflattedDottedPropertyNamesTests.cs.