Roll buffer files on size/limit total disk usage in durable mode #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52 highlights some problems in per-day buffer files when log volumes are high.
This PR takes advantage of the new functionality in Serilog.Sinks.File 4.0 to roll buffer files on 100 MB boundaries, so that space can be reclaimed within the one day period.
The PR is breaking - slightly - in that the parameter previously called
bufferFileSizeLimitBytes
has been renamed tobufferSizeLimitBytes
and is applied to the whole file set instead of individual files. By doing this, we can better control disk usage, and ensure the oldest data is discarded when the limit is reached.In practice the change in semantics shouldn't have a huge negative impact - the behavior upon hitting the old limit was undesirable, so the value is usually set high.