Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Fix to update dependabot minor update #184

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

WatanabeToshimitsu
Copy link
Contributor

What?

Fix to update dependabot minor update

Why?

諸々テストが追加されて,パッチバージョンでもテストが通れば自動でマージしていいくらいになったと思うので

See also

#154
#146

@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WatanabeToshimitsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@WatanabeToshimitsu WatanabeToshimitsu requested review from d-hayashi and yusukefs and removed request for yuri-sakai January 13, 2022 08:13
@hdl-service hdl-service added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2022
@WatanabeToshimitsu
Copy link
Contributor Author

WatanabeToshimitsu commented Jan 13, 2022

@yusukefs
@d-hayashi
マイナーバージョンまでのアップデートについてはほぼ気楽にやっていることが多いので,この際 CI 通れば自動マージしちゃっていいんじゃないか と考えて PR 出しました
自分でもちょっと楽観的かなと思っているので,是非ご意見頂戴したいです

@yusukefs
Copy link
Contributor

@WatanabeToshimitsu
テストありますし僕は賛成です!

@d-hayashi
Copy link
Contributor

良いと思います!

@d-hayashi
Copy link
Contributor

@WatanabeToshimitsu
renovate と dependabot を共存させていく感じです?

@WatanabeToshimitsu
Copy link
Contributor Author

@d-hayashi

@WatanabeToshimitsu renovate と dependabot を共存させていく感じです?

そのつもりはないです!
renovate の導入がいつになるか分からんので,とりあえず dependabot の設定を弄ってみた感じです

@d-hayashi
Copy link
Contributor

なるほど
LGTM!

@WatanabeToshimitsu WatanabeToshimitsu merged commit 474f095 into master Jan 14, 2022
@hdl-service hdl-service deleted the fix/automerge-dependabot-minor-update branch January 14, 2022 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants