Add timezone to formatISO #1576
Conversation
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
|
I'll fix the CI test slightly later™ |
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
| @@ -12,7 +12,7 @@ import addLeadingZeros from '../_lib/addLeadingZeros/index.js' | |||
| * | |||
| * @param {Date|Number} date - the original date | |||
| * @param {Object} [options] - an object with options. | |||
| * @param {'extended'|'basic'} [options.format='extended'] - if 'basic', hide delimiters between date and time values. | |||
| * @param {'extended'|'basic'} [options.format='extended'] - if 'basic', hide delimiters between date and time values and hide time zone. | |||
There was a problem hiding this comment.
@kossnocorp I have updated the JSDoc comments. Please take a look!
There was a problem hiding this comment.
Oh god damn, that's the line that confused me. The docs are just misleading. I'll fix that in the master.
|
@imballinst please hold on, the review is coming. I don't like the fact that timezone presence is tied to delimiters, because they aren't connected. But I can't find a solution yet, and without a solution, the review is pointless. I hope @leshakoss can help me here because it was he who developed the current argument schema. |
Sorry for that! I thought you missed this. Thanks for clarifying! Could you tell more about "timezone tied to delimiters"? Isn't the timezone only tied to the Alternatively, we could add something like, |
You're right I completely missed it. I'm not even sure what I was talking about lol. Sorry about that. I took a second look at the code and the current behavior is what we need. Sorry again. |
Fixes #1559.
Signed-off-by: Try Ajitiono [email protected]