fix parseISO not returning Invalid Date when there are space(s) in passed string

[imballinst]

Fixes #1748. This PR adds additional validation when a datetime string is split using the existing RegEx in splitDateString, hence parseISO will return "Invalid Date" for strings with space(s).

Current

// Since we only check first 2 array elements, it won't resolve to "Invalid Date".
splitDateString('2014-02-11T07:00:00  basketball'); // ['2014-02-11', '07:00:00', 'basketball']
parseISO('2014-02-1107:00:00  basketball'); // 2014-02-11T00:00:00.000Z (I'm in GMT+7)

// This is also the same for date-only string.
splitDateString('2014-02-11  basketball'); // ['2014-02-11', '', 'basketball']
parseISO('2014-02-11  basketball'); // 2014-02-10T17:00:00.000Z (if time is not specified, we use 12am)

This PR

With that, the solution of this PR is to always check the resulting array length from splitDateString. If the array length is more than 2, then it contains space(s) and it should resolve to "Invalid Date".

This is also considering the fact that ISO8601-formatted dates don't have spaces in it (source: https://www.w3.org/TR/NOTE-datetime).

splitDateString('2014-02-11T07:00:00  basketball'); // ['2014-02-11', '07:00:00', 'basketball']
parseISO('2014-02-11T07:00:00  basketball'); // Invalid Date

splitDateString('2014-02-11  basketball'); // ['2014-02-11', '', 'basketball']
parseISO('2014-02-11  basketball'); // Invalid Date

Signed-off-by: Try Ajitiono [email protected]

[kossnocorp]

Thanks, it makes sense!