Fix formatRFC3339: adjust formatting offset for timezones with minutes #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (e.g. India, Australia) * Affected time-zones: Australia, West of Canada, India and Sri Lanka, Islands near by New Zeland. I think India is the most populated affected timezone * Caused formatting offset in expression like `+5.5:30` instead `+05:30`) which makes invalid date in `parseISO()` * It was simple mistake in division (`-330/60` caused `5.5` hours offset instead full hour) * I used `toInteger` as it already have condition for positive and negative offset, using `Math.floot()` or `Math.ceil()`. I see in some other functions * Add specs for interesting and regular timezones for this use case
piotrl
changed the title
This was referenced Aug 22, 2020
kossnocorp
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with minutes (e.g. India, Australia).
First of all, thanks for making such a modular library! Once we found the issue, we could fix it in minutes in production by forking single-function :)
+5.5:30instead+05:30) which makes invalid date inparseISO()-330/60caused5.5hours offset instead full hour)toIntegeras it already have condition for positive and negative offset, usingMath.floot()orMath.ceil(). I see in some other functions