Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Greek locale files (el) #334

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Conversation

teoulas
Copy link
Member

@teoulas teoulas commented Dec 13, 2016

Support for Greek.

Greek has genders and some formats ("D MMMM" and "DD MMMM") should output the month in genitive.

@leshakoss
Copy link
Contributor

@teoulas thanks a lot! 🌟

"D MMMM" and "DD MMMM"

What about "Do MMMM"?

'Q': 'ο',
'W': 'η'
}
Object.keys(ordinalGenders).map(function (formatterToken) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teoulas Please don't use Object.keys (it doesn't work in IE8, sadly). Separate array which is a copy of Object.keys(ordinalGenders) is ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE8? Wow, I completely forgot that! I'll change it.

@teoulas
Copy link
Member Author

teoulas commented Dec 13, 2016

Good point about "Do MMMM". It's not a common format, but momentjs supports it correctly. I will take a look.

@leshakoss
Copy link
Contributor

@teoulas

Good point about "Do MMMM". It's not a common format, but momentjs supports it correctly. I will take a look.

In Russian locale we made it like this:

https://github.com/date-fns/date-fns/blob/master/src/locale/ru/build_format_locale/index.js#L75

@teoulas
Copy link
Member Author

teoulas commented Dec 13, 2016

@leshakoss thanks for the tip, that's exactly how I implemented it as well!

@leshakoss
Copy link
Contributor

@teoulas great work! Please fix the linting problem and we're good to go https://travis-ci.org/date-fns/date-fns/builds/183575458#L230

@teoulas
Copy link
Member Author

teoulas commented Dec 13, 2016

Fixed linting and squashed commits. Good to go. 🚀

@leshakoss leshakoss merged commit dcc934b into date-fns:master Dec 13, 2016
@teoulas teoulas deleted the greek-locale branch December 13, 2016 17:15
@leshakoss
Copy link
Contributor

@teoulas thank you for your contribution! 🇬🇷 Greek locale was released with 1.19.0 (diff: v1.18.0...v1.19.0)

@teoulas
Copy link
Member Author

teoulas commented Dec 13, 2016

👍 Thanks for the super quick response and new release!

@leshakoss leshakoss mentioned this pull request Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants