move comma-microsecond logic from timelex to parser #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need tests before being mergeable. Before that we need to make a decision about the behaviors that this changes, in particular, do we allow commas as a decimal separator for minutes, or only for seconds? If we allow them for minutes, I'll need to patch this. |
pganssle
reviewed
Sep 24, 2018
| @@ -57,7 +57,7 @@ | |||
| # take off their plate. | |||
| class _timelex(object): | |||
| # Fractional seconds are sometimes split by a comma | |||
| _split_decimal = re.compile("([.,])") | |||
| _split_decimal = re.compile("([.])") | |||
There was a problem hiding this comment.
If we're moving the logic into the parser, we don't have to use a compiled regular expression, since I believe token.split('.') will work.
There was a problem hiding this comment.
Good idea.
IIRC the status of this is that it needs to entail zero behavioral changes. That is not yet the case with this PR; I'll move this up the priority list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks small, but is somewhat far-reaching.
Treat commas as a decimal exclusively in seconds. ATM if parse
'2003 May 4, 14:10,7'the10,7gets treated as "10.7 minutes", which I do not think is intended.By getting rid of the comma in
_split_decimal, we can further simplify simplify+optimize timelex #732 to get rid of the second-pass which is the main point of ugliness there.If there is no decimal separator in a seconds token, return
Noneas the microseconds instead of 0. Down the road this will be useful for keeping track of resolution information.