Skip to content

Commit

Permalink
add note about failures with start_with_ALS ref #41
Browse files Browse the repository at this point in the history
  • Loading branch information
david-cortes committed Mar 20, 2023
1 parent 726f35c commit 03d1adb
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 2 deletions.
4 changes: 4 additions & 0 deletions R/fit.R
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,10 @@ NULL
#' This might help to speed up the procedure by starting closer to an
#' optimum. This option is not available when the side information is passed
#' as sparse matrices.
#'
#' Note that this option will not work (will throw an error) if there are
#' users or items without side information, or if the input data is otherwise
#' problematic (e.g. users/items which are duplicates of each other).
#' @param apply_log_transf Whether to apply a logarithm transformation on the values of `X`
#' (i.e. `X := log(X)`)
#' @param NA_as_zero Whether to take missing entries in the `X` matrix as zeros (only
Expand Down
6 changes: 5 additions & 1 deletion cmfrec/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4395,7 +4395,7 @@ def from_model_matrices(A, B, glob_mean=0., precompute=True,
if precompute:
new_model.force_precompute_for_predictions()
return new_model


class CMF_implicit(_CMF):
"""
Expand Down Expand Up @@ -7844,6 +7844,10 @@ class ContentBased(_OMF_Base):
This might help to speed up the procedure by starting closer to an
optimum. This option is not available when the side information is passed
as sparse matrices.
Note that this option will not work (will throw an error) if there are
users or items without side information, or if the input data is otherwise
problematic (e.g. users/items which are duplicates of each other).
nthreads : int
Number of parallel threads to use. If passing a negative number, will
use the same formula as joblib (maximum threads + 1 - nthreads).
Expand Down
5 changes: 5 additions & 0 deletions include/cmfrec.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -1616,6 +1616,11 @@ CMFREC_EXPORTABLE int_t predict_X_old_most_popular
might reduce fitting times due to starting closer
to a local optimum. Sparse inputs for 'U' and 'I'
are not supported with this option.
Note that this option will not work (will throw an
error) if there are users or items without side
information, or if the input data is otherwise
problematic (e.g. users/items which are duplicates of
each other).
Recommended value: true

--- For prediction functionality ---
Expand Down
6 changes: 5 additions & 1 deletion man/fit.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 03d1adb

Please sign in to comment.