solve CRAN complaints

CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required (VERSION 3.12.4)
-project (cmfrec VERSION 3.6.0)
+project (cmfrec VERSION 3.5.1)
 set(CMAKE_BUILD_TYPE Release)
 
 ### Note: this build script allows configuring 4 things manually:

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: cmfrec
 Type: Package
 Title: Collective Matrix Factorization for Recommender Systems
-Version: 3.6.0
+Version: 3.5.1
 Authors@R: c(
   person(given="David", family="Cortes", role=c("aut", "cre", "cph"),
          email="[email protected]"),

setup.py

@@ -309,7 +309,7 @@ def test_supports_clang_reassociate(self):
 setup(
     name  = "cmfrec",
     packages = ["cmfrec"],
-    version = '3.5.0-1',
+    version = '3.5.1',
     description = 'Collective matrix factorization',
     author = 'David Cortes',
     author_email = '[email protected]',

src/helpers.c

@@ -964,15 +964,17 @@ int_t random_parallel(ArraysToFill arrays, int_t seed, bool normal, int nthreads
     const size_t BUCKET_SIZE = (size_t)1 << 18; /* <- a bit over 250k */
     rng_state_t initial_state[4];
     seed_state(seed, initial_state);
-    if (arrays.sizeA + arrays.sizeB < BUCKET_SIZE)
+    if (arrays.sizeA + arrays.sizeB <= BUCKET_SIZE)
     {
         rnorm_singlethread(arrays, initial_state);
         return 0;
     }
 
     const size_t buckA  = arrays.sizeA  / BUCKET_SIZE + (arrays.sizeA %  BUCKET_SIZE) != 0;
     const size_t buckB  = arrays.sizeB  / BUCKET_SIZE + (arrays.sizeB %  BUCKET_SIZE) != 0;
-    const size_t tot_buckets = buckA + buckB;
+    const size_t tot_buckets = max2(1, buckA + buckB);
+    /* Note: the condition above is not needed, but GCC12 complains otherwise
+       and by extension CRAN complains too */
 
     real_t **ptr_bucket = (real_t**)malloc(tot_buckets*sizeof(real_t*));
     size_t *sz_bucket   =  (size_t*)malloc(tot_buckets*sizeof(size_t));