Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HashTable insert doesn't actually return old value #73

Closed
davidcole1340 opened this issue Sep 19, 2021 · 0 comments
Closed

HashTable insert doesn't actually return old value #73

davidcole1340 opened this issue Sep 19, 2021 · 0 comments

Comments

@davidcole1340
Copy link
Owner

No description provided.

davidcole1340 added a commit that referenced this issue Sep 19, 2021
@davidcole1340
Remove zval return from array insert functions #73
9ea49d0 
The functions actually returned references to the new zval value, so
there's not much point in returning.
davidcole1340 added a commit that referenced this issue Sep 19, 2021
@davidcole1340
Remove zval return from array insert functions #73
47ea989 
The functions actually returned references to the new zval value, so
there's not much point in returning.
davidcole1340 added a commit that referenced this issue Sep 21, 2021
@davidcole1340
Refactor ZendHashTable and Zval (#76)
7c484a0 
* Call zval destructor when changing zval type and dropping

* Remove zval return from array insert functions #73

The functions actually returned references to the new zval value, so
there's not much point in returning.

* Remove `ZendHashTable` wrapper

Replaced by returning references to the actual hashtable, and having a
new type `OwnedHashTable` when creating a new hashtable.

* Remove pointless `drop` field from `OwnedHashTable`

* Added `Values` iterator for Zend hashtable

* Change iterators to double ended and exact size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidcole1340