-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_identical for zvals #217
Merged
ptondereau
merged 2 commits into
davidcole1340:master
from
Christian-Rades:add-is-identical
Jan 19, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,8 +11,8 @@ use crate::{ | |
convert::{FromZval, FromZvalMut, IntoZval, IntoZvalDyn}, | ||
error::{Error, Result}, | ||
ffi::{ | ||
_zval_struct__bindgen_ty_1, _zval_struct__bindgen_ty_2, zend_is_callable, zend_resource, | ||
zend_value, zval, zval_ptr_dtor, | ||
_zval_struct__bindgen_ty_1, _zval_struct__bindgen_ty_2, zend_is_callable, | ||
zend_is_identical, zend_resource, zend_value, zval, zval_ptr_dtor, | ||
}, | ||
flags::DataType, | ||
flags::ZvalTypeFlags, | ||
|
@@ -327,6 +327,18 @@ impl Zval { | |
unsafe { zend_is_callable(ptr as *mut Self, 0, std::ptr::null_mut()) } | ||
} | ||
|
||
/// Checks if the zval is identical to another one. | ||
/// This works like `===` in php. | ||
/// | ||
/// # Parameters | ||
/// | ||
/// * `other` - The the zval to check identity against. | ||
pub fn is_identical(&self, other: &Self) -> bool { | ||
let self_p: *const Self = self; | ||
let other_p: *const Self = other; | ||
unsafe { zend_is_identical(self_p as *mut Self, other_p as *mut Self) } | ||
} | ||
|
||
Comment on lines
+330
to
+341
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This addition is good! 👍🏻 |
||
/// Returns true if the zval contains a pointer, false otherwise. | ||
pub fn is_ptr(&self) -> bool { | ||
self.get_type() == DataType::Ptr | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff looks way better now 😅