-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dealing with streams #11
Comments
I'm sorry, but I don't think it's useful for the average user to have their subtitles in an entirely different path than their movies. This also makes moving movies to other devices or backup a lot less convenient. |
Closing this now. Feel free to comment if you have any further questions/suggestions. |
Can this be added as an optional feature? Any tips would be appreciated. 👍 |
Tries to fix davidde#11 Has a bug in even after finding subtitle will reject saying not found Maybe result.stdout doesn't find required result.
I'll reopen this for now, so I remember looking into this when I next update the script. Can you elaborate a bit on how you'd expect this to work?
|
|
Tries to fix davidde#11 Has a bug in even after finding subtitle will reject saying not found Maybe result.stdout doesn't find required result.
Tries to fix davidde#11 Has a bug in even after finding subtitle will reject saying not found Maybe result.stdout doesn't find required result.
Still wondering a few things:
If you do not have a video locally, it would be required to store the subtitles in a central path. Otherwise I don't really see the point of putting them elsewhere? Is it even desirable for most users to do so? Am I misunderstanding something here? |
The more I think of it, it comes as a very niche border case, which most people wouldn't use. Or won't require. I guess if someone requires this in future, they can always refer to the fork I made. (Not exactly great at Lua, just modified some parts of your code) |
Thanks for explaining, I'll look into your code when I next update. Note it's probably still a good idea to save the subtitles; otherwise you'll have to re-download them every time and they don't stay up forever. |
any update on this? |
Can you update the autosub available for Vietnamese language? Thanks a lot! |
In reference to #8 (comment), for http streams (e. g. from webtorrent-cli), subliminal’s output directory should be a directory on the user’s filesystem. Maybe the script should default to an actual path (like
.config/mpv/autosubs
) instead of the variabledirectory
and pass it on to the mpv optionsub-file-paths
.The text was updated successfully, but these errors were encountered: