Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error processing Facebook OAuth reply #103

Closed
stephen-smith opened this issue Mar 3, 2018 · 3 comments
Closed

Error processing Facebook OAuth reply #103

stephen-smith opened this issue Mar 3, 2018 · 3 comments
Labels
bug change under review Fix was uploaded and is pending for review/approval

Comments

@stephen-smith
Copy link 

[2018-03-02 20:14:48,909] [HTTP-87] ERROR com.google.gerrit.pgm.http.jetty.HiddenErrorHandler : Error in GET /oauth?code=AQAtIjkUAwyE6qUqGT_e23HOUnYmadRAsCPpdFA1ffo-hn0Br1W5QOiBgR0hePQbUXPujjRdbZZJzP_NdfO1dpYsQy9SDm-ftdUHpeVLraFuxCLSm1Xmi5_gAwd8VPvvKVPuTWkoVzTWseB27YoQXzDSo1rpUtWY3S3Hat_gpqKYEXK5E-ifOccXuJTYfWklxm-Rk3xxyT2AaecW5i8w-IkQZ-HSHDukY0a0LH3Z-Qervtvw46vkdjUhgfElLMkrteX8uTAahdZcPK2nXC3aFbPVhlLGjTUbJjqW3fjgzzlpYN1n8xT4HoBt_l-yMqqu2-w&state=2Iow4goZpV15S4MIUoUpulmoE5YU8MidzgYq_787AkY
org.scribe.exceptions.OAuthException: Response body is incorrect. Can't extract a token from this: '{"access_token":"EAACe33RVXDwBAFhO9KMX0ZC0eoUUK7lHkWmhZAf4ZCj8ZBcgcFnGQOgZBYGUjBvNrCCZCBN5mxnhZBZCLUSJSmQwb3tVEA4pdX47j8kFjyoW1hg6Qf2ZAk9giTcsilHRldaUmIeGZBTe8dSnYMw5c2oGozgFlQnggeUywIDMK6IurH4QZDZD","token_type":"bearer","expires_in":5183999}'
        at org.scribe.extractors.TokenExtractor20Impl.extract(TokenExtractor20Impl.java:32)
        at org.scribe.oauth.OAuth20ServiceImpl.getAccessToken(OAuth20ServiceImpl.java:37)
        at com.googlesource.gerrit.plugins.oauth.FacebookOAuthService.getAccessToken(FacebookOAuthService.java:123)

Looks to me like the token is in the access_token key, so I'm not sure what's wrong.
@davido
Copy link
Owner

davido commented Mar 3, 2018

Confirmed:

2018-03-03 15:33:24,638] [HTTP-102] WARN  org.eclipse.jetty.servlet.ServletHandler : /oauth
org.scribe.exceptions.OAuthException: Response body is incorrect. Can't extract a token from this: '{"access_token":"EAADxxxxxxxxxxxx","token_type":"bearer","expires_in":5183999}'
	at org.scribe.extractors.TokenExtractor20Impl.extract(TokenExtractor20Impl.java:32)
	at org.scribe.oauth.OAuth20ServiceImpl.getAccessToken(OAuth20ServiceImpl.java:37)
	at com.googlesource.gerrit.plugins.oauth.FacebookOAuthService.getAccessToken(FacebookOAuthService.java:123)
	at com.google.gerrit.httpd.auth.oauth.OAuthSession.login(OAuthSession.java:105)

Working on a fix.

@davido davido added bug change under review Fix was uploaded and is pending for review/approval labels Mar 3, 2018
@davido
Copy link
Owner

davido commented Mar 4, 2018

https://gerrit-review.googlesource.com/163932.

davido added a commit that referenced this issue Mar 4, 2018
@davido
FacebookApi: Use access token json extractor
7ae0062 
Fixes: [1] / #103.

[1] #103

Change-Id: I14ea93a857a2f9cfb425ede1f7923ec42f221931
lucamilanesio pushed a commit to GerritCodeReview/plugins_oauth that referenced this issue Mar 5, 2018
@davido
FacebookApi: Use access token json extractor
b637a18 
Fixes: [1] / #103.

[1] davido/gerrit-oauth-provider#103

Change-Id: I14ea93a857a2f9cfb425ede1f7923ec42f221931
@davido
Copy link
Owner

davido commented Mar 5, 2018

Fixed and released: [1].

[1] https://github.com/davido/gerrit-oauth-provider/releases/tag/v2.14.6.2

@davido davido closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug change under review Fix was uploaded and is pending for review/approval
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephen-smith @davido