Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed external ids missing provider name prefix #82

Closed
davido opened this issue Feb 2, 2017 · 1 comment
Closed

Exposed external ids missing provider name prefix #82

davido opened this issue Feb 2, 2017 · 1 comment
Labels
bug

Comments

@davido
Copy link
Owner

davido commented Feb 2, 2017 •
edited
Loading

In current implementation, all supported OAuth providers use non-prefixed provider internal id as users external_id. There is potentially a chance for collisions.

Current situation:

Github-OAuth-Provider, id = "42"
Google-OAuth-Provider, id = "12984639874612837"

Should be:

Github-OAuth-Provider, id = "github-oauth:42"
Google-OAuth-Provider, id = "google-oauth:12984639874612837"

To fix it, we would need to support data migration from non prefixed to prefixed user ids.
@davido davido added the bug label Feb 2, 2017
@davido davido mentioned this issue Feb 2, 2017
Closed
davido added a commit that referenced this issue Feb 4, 2017
@davido
Prefix user id with oauth provider name
879bbae 
To migrate the legacy user id, fixLegacyUserId property must be set to
true for all providers.

Bug: Issue #82
Change-Id: I36833b90280b158172423180358faf90ac2b6718
@davido
Copy link
Owner Author

davido commented Feb 4, 2017

Fixed with: 879bbae.

@davido davido closed this as completed Feb 4, 2017
@davido davido mentioned this issue Feb 6, 2017
Closed
lucamilanesio pushed a commit to GerritCodeReview/plugins_oauth that referenced this issue Feb 9, 2017
@davido
Prefix user id with oauth provider name
6663ea4 
To migrate the legacy user id, fixLegacyUserId property must be set to
true for all providers.

Bug: Issue davido/gerrit-oauth-provider#82
Change-Id: I36833b90280b158172423180358faf90ac2b6718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davido