Translate pt-br date format #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenderjean
reviewed
Aug 6, 2019
wenderjean
reviewed
Aug 6, 2019
wenderjean
reviewed
Aug 6, 2019
wenderjean
reviewed
Aug 6, 2019
GQuirino
changed the title
GQuirino
force-pushed
the
translate-dates-on-workers-table
branch
from
823e147 to
15dd98b
Compare
|
@wenderjean I updated with these suggestions. |
GQuirino
changed the title
added 2 commits
August 8, 2019 10:37
wenderjean
approved these changes
Aug 9, 2019
|
@davydovanton Do you have any consideration here? Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related do #132
To prevent a big translate file with months names, i adopted the following format:
day/month/yearpt-br.ymlandmonth/day/yearas default to prevent errors when the translation is missing.