fix: accept expired artifacts with documentation url #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice, thanks! |
7 tasks
kodiakhq bot
referenced
this pull request
in weareinreach/TransMascFutures
Mar 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/cache](https://togithub.com/actions/cache) | action | digest | `ab5e6d0` -> `0c45773` | | [chromaui/action](https://togithub.com/chromaui/action) | action | digest | `306092d` -> `da24ada` | | [dawidd6/action-download-artifact](https://togithub.com/dawidd6/action-download-artifact) | action | patch | `v3.1.2` -> `v3.1.4` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | digest | `3ab4101` -> `05963f4` | --- ### Release Notes <details> <summary>dawidd6/action-download-artifact (dawidd6/action-download-artifact)</summary> ### [`v3.1.4`](https://togithub.com/dawidd6/action-download-artifact/releases/tag/v3.1.4) [Compare Source](https://togithub.com/dawidd6/action-download-artifact/compare/v3.1.3...v3.1.4) #### What's Changed - build(deps): bump adm-zip from 0.5.10 to 0.5.12 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dawidd6/action-download-artifact/pull/282](https://togithub.com/dawidd6/action-download-artifact/pull/282) - build(deps): bump [@​actions/artifact](https://togithub.com/actions/artifact) from 2.1.2 to 2.1.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dawidd6/action-download-artifact/pull/280](https://togithub.com/dawidd6/action-download-artifact/pull/280) - fix: accept expired artifacts with documentation url by [@​wdconinc](https://togithub.com/wdconinc) in [https://github.com/dawidd6/action-download-artifact/pull/283](https://togithub.com/dawidd6/action-download-artifact/pull/283) #### New Contributors - [@​wdconinc](https://togithub.com/wdconinc) made their first contribution in [https://github.com/dawidd6/action-download-artifact/pull/283](https://togithub.com/dawidd6/action-download-artifact/pull/283) **Full Changelog**: dawidd6/action-download-artifact@v3...v3.1.4 ### [`v3.1.3`](https://togithub.com/dawidd6/action-download-artifact/releases/tag/v3.1.3) [Compare Source](https://togithub.com/dawidd6/action-download-artifact/compare/v3.1.2...v3.1.3) #### What's Changed - node_modules: upgrade by [@​dawidd6](https://togithub.com/dawidd6) in [https://github.com/dawidd6/action-download-artifact/pull/276](https://togithub.com/dawidd6/action-download-artifact/pull/276) - build(deps): bump [@​actions/artifact](https://togithub.com/actions/artifact) from 2.1.1 to 2.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dawidd6/action-download-artifact/pull/277](https://togithub.com/dawidd6/action-download-artifact/pull/277) **Full Changelog**: dawidd6/action-download-artifact@v3.1.2...v3.1.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday,before 4am on Thursday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #364 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that, recently, GitHub has started to return the expired artifact error along with a URL with more documentation. This leads to the equality error condition not being satisfied, and the error to be thrown even when the settings ask for errors to be ignored:
(followed by failed pipeline).
This PR changes the expiration error message to only require the error message to start with "Artifact has expired" and allowing additional text. With this PR, the above pipeline does not return with an error but just ignores the expiration error as intended.