refactor: active profile error handling (#1281)

Signed-off-by: Toma Puljak <[email protected]>

cmd/daytona/config/config.go

@@ -86,14 +86,20 @@ func GetConfig() (*Config, error) {
 	return &c, nil
 }
 
+var ErrNoProfilesFound = errors.New("no profiles found. Run `daytona serve` to create a default profile or `daytona profile add` to connect to a remote server")
+
 func (c *Config) GetActiveProfile() (Profile, error) {
+	if len(c.Profiles) == 0 {
+		return Profile{}, ErrNoProfilesFound
+	}
+
 	for _, profile := range c.Profiles {
 		if profile.Id == c.ActiveProfileId {
 			return profile, nil
 		}
 	}
 
-	return Profile{}, errors.New("active profile not found")
+	return Profile{}, errors.New("active profile not found. Set an active profile with `daytona profile use`")
 }
 
 func (c *Config) Save() error {

pkg/cmd/cmd.go

@@ -4,7 +4,6 @@
 package cmd
 
 import (
-	"errors"
 	"fmt"
 	"os"
 	"os/signal"
@@ -94,13 +93,6 @@ func Execute() error {
 		return cmd.Help()
 	}
 
-	if !isCompletion {
-		err = ensureProfiles(cmd)
-		if err != nil {
-			return err
-		}
-	}
-
 	err = rootCmd.Execute()
 
 	endTime := time.Now()
@@ -157,38 +149,6 @@ func validateCommands(rootCmd *cobra.Command, args []string) (cmd *cobra.Command
 	return currentCmd, flags, false, nil
 }
 
-func ensureProfiles(cmd *cobra.Command) error {
-	exemptions := []string{
-		"daytona",
-		"daytona autocomplete",
-		"daytona help",
-		"daytona docs",
-		"daytona generate-docs",
-		"daytona version",
-		"daytona profile add",
-		"daytona serve",
-		"daytona server",
-		"daytona ide",
-		"daytona telemetry enable",
-		"daytona telemetry disable",
-	}
-
-	if slices.Contains(exemptions, cmd.CommandPath()) {
-		return nil
-	}
-
-	c, err := config.GetConfig()
-	if err != nil {
-		return err
-	}
-
-	if len(c.Profiles) == 0 {
-		return errors.New("no profiles found. Run `daytona serve` to create a default profile or `daytona profile add` to connect to a remote server.")
-	}
-
-	return nil
-}
-
 func SetupRootCommand(cmd *cobra.Command) {
 	// Common commands
 	cmd.AddCommand(AutoCompleteCmd)

pkg/cmd/profile/list.go

@@ -23,6 +23,10 @@ var profileListCmd = &cobra.Command{
 			return err
 		}
 
+		if len(c.Profiles) == 0 {
+			return config.ErrNoProfilesFound
+		}
+
 		if format.FormatFlag != "" {
 			formattedData := format.NewFormatter(c.Profiles)
 			formattedData.Print()