feat: commit signing using ssh and gpg

[divanshu-go]

feat: commit signing using ssh and gpg

Description

add support for commit signing when adding git provider(s)

• This change requires a documentation update
• I have made corresponding changes to the documentation

Related Issue(s)

Closes #370
/claim #370

Screenshots

Notes

In order to sign your commits with ssh . ssh keys need to be present on your local system and should be added to your github or gitlab account. my pr simplifies the work for manually doing setup for ssh commit signing in the gitconfig file of the project.
for the ssh key field : paste the same key that you pasted in the add ssh key in github or gitlab

[divanshu-go]

@Tpuljak

can you please assist here. I am succesfull in adding git provider but these values are not getting stored and am not able to understand what to do

[Tpuljak]

@Tpuljak can you please assist here. I am succesfull in adding git provider but these values are not getting stored and am not able to understand what to do

@bryans-go from what I can see, you don't pass the properties from SetGitProviderConfig to GitProviderConfig here https://github.com/daytonaio/daytona/blob/main/pkg/api/controllers/gitprovider/gitprovider.go#L134

[divanshu-go]

[divanshu-go]

now the ssh signing is working perfectly @Tpuljak
Some of the git providers does not show verified commits bagde even on signed commits by git while some also dont have proper docs on this . what should we do there ?

[Tpuljak]

Some of the git providers does not show verified commits bagde even on signed commits by git while some also dont have proper docs on this . what should we do there ?

Could you let us know which providers don't show the verified badge but should?

P.S. Nice work on the solution!

[divanshu-go]

https://jira.atlassian.com/browse/BCLOUD-3166. Bitbucket doesn't have this feature yet and gitness don't have a proper docs on ssh and gpg signing while

[Tpuljak]

https://jira.atlassian.com/browse/BCLOUD-3166. Bitbucket doesn't have this feature yet and gitness don't have a proper docs on ssh and gpg signing while

Then let's not show that input at all if the user selects Bitbucket or Gitness

[divanshu-go]

Ok

[divanshu-go]

@Tpuljak Done

[divanshu-go]

@bryans-go I had something else in mind with https://github.com/daytonaio/daytona/pull/1146/files#r1778545525.

"none" shouldn't be defined as an option here.

The solution I was aiming for included setting up a variable inside GitProviderSelectionView that would be a helper variable for selecting the signing method. It would include ssh gpg and none as options. After the form runs inside that function, you would check the value of that variable and assign GitProviderView to the appropriate value (if none then nil).

@Tpuljak I did what you said but problem is that due to the fact that signing method is a enum . the following problem has arisen. please assist with it

[Tpuljak]

@bryans-go I had something else in mind with https://github.com/daytonaio/daytona/pull/1146/files#r1778545525.
"none" shouldn't be defined as an option here.
The solution I was aiming for included setting up a variable inside GitProviderSelectionView that would be a helper variable for selecting the signing method. It would include ssh gpg and none as options. After the form runs inside that function, you would check the value of that variable and assign GitProviderView to the appropriate value (if none then nil).

@Tpuljak I did what you said but problem is that due to the fact that signing method is a enum . the following problem has arisen. please assist with it

@bryans-go please try to do some debugging yourself. Not completely sure but this might be part of the issue. The signing method is a string when passed here when it should be a pointer to a string.
Also, make sure to wipe your config between these changes since these are all breaking to one another.

[divanshu-go]

daytona/pkg/views/gitprovider/select.go

Line 179 in 0606c74

gitProviderAddView.SigningMethod = nil

I added the following line by explicitly setting the value as nil, and now everything works perfectly.

PS: I tried setting signing method as pointer to string but it didn't worked as expected but the following method was successful .

[divanshu-go]

@Tpuljak Done !

[Tpuljak]

Nice work! Everything works except the one comment I left below.

[divanshu-go]

Its working now

[Tpuljak]

Nice work!

[divanshu-go]

added logic for displaying signing method.

[divanshu-go]

@Tpuljak do we require any further changes ?

[Tpuljak]

One more comment to resolve before I can approve

[divanshu-go]

@Tpuljak The PR has both approvals now.
If possible, could you merge it today? Would really appreciate it. Thanks! 😊

[Tpuljak]

@bryans-go as you can see above your message, one more review was requested. No need to ping us for this. It will be merged once it's ready.