-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gitness/harness prebuild webhook #1199
feat: gitness/harness prebuild webhook #1199
Conversation
35c4f09
to
979f99a
Compare
18060a3
to
c5c72a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move the PR to draft until you address the comment below. Please provide a video where you test the PR with commit interval and trigger files.
b1f7c4d
to
33b369a
Compare
done.mp4 |
@Tpuljak Gitness api for listing all commits has param called |
But how are you supposed to know how many commits are made between Forget the prebuild trigger for now, just focus on |
@Tpuljak I think |
It means exactly that sha. It might be the latest one but it might not be. It's not important if it's the last one of not. |
@Tpuljak oh I thought it will be latest one every time. My bad. |
@Tpuljak Updated the changes. Please Take a look I will upload the video soon |
clideo_editor_5970bf36aec245e193096b90f9d59372.mp4 |
@the-johnwick I just tried adding a Gitness provider after cleaning up the Daytona config and it seems that the base API url ends up empty in the database? Can you check once more on your side? Workspace creation fails with 500 as a result |
@idagelic Sure I will check whats happening. |
Signed-off-by: the-johnwick <[email protected]>
@idagelic Solved this issue. We were not setting it while listing. |
@idagelic Apologies for the delayed commit. I accidentally pushed the commit to my fork's |
Hi @idagelic, I just wanted to kindly check in on the PR status and see if there's any feedback when you have a moment. Thanks in advance! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work for url's containing capital letters because you didn't clean up the repository url. Attach another video when fixed
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
Signed-off-by: the-johnwick <[email protected]>
6c65449
to
2ccb7b4
Compare
Signed-off-by: the-johnwick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Thank You so much 😊 |
gitness/harness prebuild webhook
Description
This PR add Prebuild hook for gitness/harness.
/claim #997
ee.mp4