-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: non-interactive prebuild add/update #1217
feat: non-interactive prebuild add/update #1217
Conversation
Signed-off-by: Abinand P <[email protected]>
Quest PR submitted!@Abiji-2020, you are attempting to solve the issue and loot this Quest. Will you be successful? Questions? Check out the docs. |
…the project-config is required while running in non-interacive mode and for the update command the same goes along with the check using the interactive mode Signed-off-by: Abinand P <[email protected]>
@Tpuljak updated the code with the given requests and also modified for better working |
Signed-off-by: Abinand P <[email protected]>
@Abiji-2020 Two checks seem to be failing. To resolve them:
|
…docs was generated. Signed-off-by: Abinand P <[email protected]>
@idagelic Updated the docs by running and resolved the issue caused in the linting |
Signed-off-by: Abinand P <[email protected]>
@idagelic I am very sorry that after removing the debugging printing statement, I forgot to format the code. Which resulted in the failing of the tests |
@Tpuljak further reviews on the PR ? |
@Abiji-2020 please do not mark conversations as resolved yourself. We will mark them as such after confirming they are resolved. |
okay, I thought that after updating the necessary , then we need to resolve it. My apologies for that. |
…updated the checking from cmd.Flags to thier respective values Signed-off-by: Abinand P <[email protected]>
…are passed in update command Signed-off-by: Abinand P <[email protected]>
add.and.update.commands.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…stead of updating the old one. Signed-off-by: Abinand P <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prebuild addedprebuild updatedon the original main branch of daytonaio. not this current branch |
Signed-off-by: Abinand P <[email protected]>
Fixed with #1244 - you can rebase with main and test once again to make sure everything works |
ok after testing it out, I will let you know |
@idagelic on checking the tests they are currently running as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a format check is failing - you can fix it by running go fmt ./...
Updating using flags is not working as expected right now - I am unable to "patch" a single property - either commit-interval or trigger-files without it setting the other one to nil.
I also left a comment at the point in the code that you should check
…d server to filter the current config required when more then one branch have the same commit Signed-off-by: Abinand P <[email protected]>
@idagelic I also have modified in https://github.com/daytonaio/daytona/blob/main/pkg/server/projectconfig/prebuild.go#L29 to include the ID when checking for the existing id, as when we have multiple prebuild for a branch and a project only top most is retrieved and the exact id is not retrieved to update. I made this change assuming that for a |
In this I guess I made a mistake that for a projectConfig and a same branch only one prebuild should be there, which is resolved now. Removed the conditon in the filter which was added by me in my previous commit |
Signed-off-by: Abinand P <[email protected]>
…d from projectConfig. Signed-off-by: Abinand P <[email protected]>
33b2eb6
to
ca0170c
Compare
I forgot to sign on while editing in the Github, so i rebased and signed it and force pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Another reviewer will take a look before we complete the merge
🧚 @Abiji-2020 congratulations for completing Quest #985 💰 A reward of $50 has been credited to you. To claim your $50 reward follow the instructions here. Questions? Check out the docs. |
Added the feature for the flags in prebuild add/update
Description
In the cobra command added the flags
Usage of update command after updating
Usage of the add command after updating
Related Issue(s)
This PR fixes #985
Screenshots
If relevant, please add screenshots.
Notes
Please add any relevant notes if necessary.
@quest-bot loot #985