fix: allow ctrl+c in provider install

[divanshu-go]

fix: allow ctrl+c in provider install

Description

• This change requires a documentation update
• I have made corresponding changes to the documentation

Related Issue(s)

Closes #1044

Screenshots

If relevant, please add screenshots.

Notes

Please add any relevant notes if necessary.

[divanshu-go]

@quest-bot loot #1044

[quest-bot]

Quest PR submitted!

@bryans-go, you are attempting to solve the issue and loot this Quest. Will you be successful?

---

Questions? Check out the docs.

[divanshu-go]

@Tpuljak
demo.webm
I think that this is the default behavior with the spinner we are using.
In daytona start I'm also not able to ctrl+c
this is same for all the loading screens using the inlinespinner and the full screen spinner func

[Tpuljak]

@Tpuljak demo.webm I think that this is the default behavior with the spinner we are using. In daytona start I'm also not able to ctrl+c this is same for all the loading screens using the inlinespinner and the full screen spinner func

@bryans-go you're right. This means that this PR is not ready for review? Please don't mark it as such until it is.

Are you wiling to solve this issue for the spinner in general so it's fixed in all the places where we use it? If so, we'll double the bounty amount through a tip.

[divanshu-go]

@Tpuljak OK
I'm willing to solve it further

[divanshu-go]

done!

[divanshu-go]

demo9.webm
Now it is gracefully exiting

[Tpuljak]

Screen.Recording.2024-10-11.at.14.39.26.mov

While this does solve allowing ctrl+c out of the spinner, it does not tackle the problem at hand which is aborting the provider installation. As you can see from my screen recording, the installation continues and completes even though I cancelled the request.
Please address that. Moving the PR to draft until you do so. Thanks.

[Tpuljak]

The solution is very over-engineered 😅

I suggest you revert everything and go back to square one.
The easiest solution to this is to look at the DownloadFile function. I suggest that the functions takes in a context (that will be passed from the request). If that context is done before the download completes, it means that the user has aborted the request and that the download should stop and be cleaned up.
I'm pretty sure this is the only change (+ the spinner thing) that the PR will require.

Moving it back to draft.

[divanshu-go]

@Tpuljak I also tried to implement the same thing that you said In your comment but once the request(POST in this case) is done by the user then how will the context get updated.
Can you please enumerate a more on your approach

[Tpuljak]

@Tpuljak I also tried to implement the same thing that you said In your comment but once the request(POST in this case) is done by the user then how will the context get updated.

All requests (in gin) have their own context on the request. I believe (I'm 99% sure) that that context is Done() if the user cancels the request. You need to test that on your own.

[divanshu-go]

Done !
@Tpuljak Thanks a lot . you did a great help

[divanshu-go]

demo-2024-10-14_20.15.46.mov

[divanshu-go]

@Tpuljak

@Tpuljak demo.webm I think that this is the default behavior with the spinner we are using. In daytona start I'm also not able to ctrl+c this is same for all the loading screens using the inlinespinner and the full screen spinner func

@bryans-go you're right. This means that this PR is not ready for review? Please don't mark it as such until it is.

Are you wiling to solve this issue for the spinner in general so it's fixed in all the places where we use it? If so, we'll double the bounty amount through a tip.

hey I think you forgot about the bounty part.

[quest-bot]

🧚 @bryans-go congratulations for completing Quest #1044

💰 A reward of $30 has been credited to you.

To claim your $30 reward follow the instructions here.

Questions? Check out the docs.

[divanshu-go]

Are you wiling to solve this issue for the spinner in general so it's fixed in all the places where we use it? If so, we'll double the bounty amount through a tip.

tip ?
is it delayed
@Tpuljak you said that you will double the bounty amount through a tip