Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: default config generation #1249

Merged
merged 3 commits into from
Oct 15, 2024
Merged

refactor: default config generation #1249

merged 3 commits into from
Oct 15, 2024

Conversation

Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Oct 15, 2024

Refactor Default Config Generation

Description

Instead of the config being generated by daytona serve it is now generated whenever requested with GetConfig. This ensures that the config is always available without having to run daytona serve first.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

@Tpuljak Tpuljak requested a review from a team as a code owner October 15, 2024 06:42
lbrecic
lbrecic previously approved these changes Oct 15, 2024
Copy link
Member

@idagelic idagelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

These commands should all still work before profile setup

Signed-off-by: Toma Puljak <[email protected]>
idagelic
idagelic previously approved these changes Oct 15, 2024
Signed-off-by: Toma Puljak <[email protected]>
@Tpuljak Tpuljak merged commit 6076e4d into main Oct 15, 2024
12 checks passed
@Tpuljak Tpuljak deleted the refactor-default-config branch October 15, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants