Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update project config git provider #1263

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat: update project config git provider #1263

merged 2 commits into from
Oct 18, 2024

Conversation

Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Oct 17, 2024

Update Project Config Git Provider

Description

This PR adds the option to update the attached git provider config on a project config. The user is only able to select from git providers that can handle the repository URL. Additionally, the user can choose None which will set the git provider config id to nil

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

@Tpuljak Tpuljak requested a review from a team as a code owner October 17, 2024 10:57
Copy link
Member

@idagelic idagelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time people will not want to change the Git provider config so this could lead to mistakes. We should sort the "active" Git provider config first (so it is "preselected") and maybe even add a " - in use" or something to the end of the option title.

Signed-off-by: Toma Puljak <[email protected]>
@Tpuljak Tpuljak merged commit 3cbadc2 into main Oct 18, 2024
12 checks passed
@Tpuljak Tpuljak deleted the pc-update-gp branch October 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants