fix: persist default provider deletion

[idagelic]

Persist default provider deletion

Description

Persists default provider/target deletion on Daytona Server restarting instead of redownloading every time

• This change requires a documentation update
• I have made corresponding changes to the documentation

Related Issue(s)

Closes #1273

[Tpuljak]

The logic seems a bit scattered to me.

I suggest the following:

1. ProviderManager.DownloadProvider writes the lock file after downloading.
2. ProviderManager.DownloadProvider has a skipIfLocked argument that will skip the download if the initial setup was locked - this will allow the controller install to redownload and for the server to skip

Seems to me that this will simplify things, especially in the Server which writes and checks lockfiles itself.

[idagelic]

@Tpuljak DownloadProvider writing the lockfile would make it so that setting preset targets never gets executed.
DownloadProvider shouldn't have a "skip if locked" argument - DownloadProvider should download the provider and if we don't want to download we should do the checks outside of that function.

[Tpuljak]

@Tpuljak DownloadProvider writing the lockfile would make it so that setting preset targets never gets executed. DownloadProvider shouldn't have a "skip if locked" argument - DownloadProvider should download the provider and if we don't want to download we should do the checks outside of that function.

Okay, lets at least go with this (#1288 (comment)) then.

[Tpuljak]

Nice work!