Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve empty list handling structure #1293

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

idagelic
Copy link
Member

Improve empty list handling structure

Description

Adds some missing empty list checks to the CLI like daytona provider list, daytona build info, daytona code/start/stop etc.
Moves some handling directly to the views package including a "tip" option when not deleting the resource
Moves formatting flag check above the empty list handling views to make sure the responses are empty arrays instead of e.g. "null"

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Screenshots

image

image

image

image

@idagelic idagelic requested a review from a team as a code owner October 25, 2024 07:23
lbrecic
lbrecic previously approved these changes Oct 25, 2024
Copy link
Contributor

@lbrecic lbrecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@idagelic idagelic merged commit 1f146b3 into main Oct 25, 2024
12 checks passed
@idagelic idagelic deleted the handle-empty-lists branch October 25, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants