Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle multiple compose files in devcontainers #1349

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Nov 19, 2024

Handle Multiple Compose Files in Devcontainers

Description

Fixes handling of multiple compose files when dockerComposeFile is defined as an array.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

Closes #1344.

Notes

All providers will need to be updated.

Can be tested with https://github.com/Tpuljak/multi-compose-devcontainer.

@Tpuljak Tpuljak marked this pull request as ready for review November 19, 2024 12:14
@Tpuljak Tpuljak requested a review from a team as a code owner November 19, 2024 12:14
Copy link
Contributor

@lbrecic lbrecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tpuljak Tpuljak merged commit e2e5818 into main Nov 22, 2024
12 checks passed
@Tpuljak Tpuljak deleted the fix-compose-file-array branch November 22, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devcontainers with multiple compose.yml doesn't build in Daytona
3 participants