feat: custom builder image #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpuljak
force-pushed
the
custom-builder-image
branch
5 times, most recently
from
ca7cbc7
to
fcb4665
Compare
- removed all hardcoded builder images - added registry credentials to local container registry Signed-off-by: Toma Puljak <[email protected]>
Tpuljak
force-pushed
the
custom-builder-image
branch
from
fcb4665
to
e1d5fa3
Compare
2 tasks
Signed-off-by: Toma Puljak <[email protected]>
Signed-off-by: Toma Puljak <[email protected]>
lbrecic
approved these changes
Nov 20, 2024
idagelic
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Builder Image
Description
Added the option to configure the custom builder image. The option in the server existed before but wasn't used in the entire build process. The image, with the appropriate registry is used in the entire creation process now.
Additionally, added container registry credentials to the local container registry service. If the local registry fails to start, the serve command does not exit. Instead, it prints out the error and lets the user know they should restart the server to restart the registry.
Related Issue(s)
Closes #1348
Notes
All providers will need to be updated.