feat: add workspace status check to code and ssh commands #821 #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Tpuljak
requested changes
Jul 22, 2024
Tpuljak
requested changes
Jul 29, 2024
|
@titanventura code looks good and everything works great. Nice work. Before I approve:
|
Signed-off-by: titanventura <[email protected]>
titanventura
force-pushed
the
feat/refactor-code-ssh-commands-status-check
branch
from
599f1ce
to
6eb9ddb
Compare
idagelic
approved these changes
Aug 2, 2024
the-johnwick
pushed a commit
to the-johnwick/daytona
that referenced
this pull request
Aug 12, 2024
Signed-off-by: titanventura <[email protected]> Signed-off-by: the-johnwick <[email protected]>
the-johnwick
pushed a commit
to the-johnwick/daytona
that referenced
this pull request
Aug 13, 2024
Signed-off-by: titanventura <[email protected]> Signed-off-by: johnwick <[email protected]>
the-johnwick
pushed a commit
to the-johnwick/daytona
that referenced
this pull request
Aug 13, 2024
Signed-off-by: titanventura <[email protected]> Signed-off-by: johnwick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Add workspace status check to code and ssh commands
Description
Currently, the code and ssh commands do not check the status of the project before opening them in IDE or doing an ssh. This change adds additional checks to do the same.
Related Issue(s)
This PR addresses issue #770
Screenshots
Notes
None
/claim #770