V2 #310
Merged
V2 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatten5
force-pushed
the
v2.2
branch
4 times, most recently
from
9d41bc9 to
8016734
Compare
This replaces the `ProjectConfig` class to be used as the main API. The new interface should be simpler to use and more intuitive as it exposes a `values` property that behaves like a dict object.
This name better reflects what `maison` is searching for.
We have some tests of the schema functionality using `pydantic`. To ensure that the `pydantic` integration works we need to add it to the test dependencies now that it's been removed from the main dependencies
The `dict` method is deprecated
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some breaking changes.
Renaming
ProjectConfigtoUserConfigThe new name better reflects what the object represents, the user's configuration.
The renaming also includes some other changes to the API:
UserConfig().values.project_namehas been renamed topackage_nameto better reflect that it refers to the configuration of the package, not the user's project.Removing
pydanticas a dependencyPreviously this was a dependency of
maison. This meant that any installs ofmaisonwill also installpydantic, butpydanticwas only used for an optional part of this package (validation). The use ofpydanticto perform validation against a schema is still preferred, but it's now up to the user to include this dependency.Dropping 3.8 support
This was done in #311