Expose tiler options via command line #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect_any_instance_of(Fog::Storage::AWS::Mock).to receive(:put_object).at_least(53).times do |*args| | ||
| expect(args.last).to eq("Content-Type" => "image/jpeg", "x-amz-acl" => "public-read") | ||
| end | ||
| `"#{@binary}" slice "#{goya}" --acl=public-read --bucket=tiled-images --s3-key=dztiles --aws-id=id --aws-secret=secret` |
There was a problem hiding this comment.
When run, this actually produces an excon error message from S3 indicating that it's actually making a real http call, and not respecting the Fog.mock! above.
|
This is great. Update CHANGELOG please and README documenting all these new things? |
mzikherman
force-pushed
the
command_line
branch
from
09e1c31 to
db31d4f
Compare
|
Ah of course! Updated docs. |
|
Merged via 894b7bc, thank you. |
This was referenced Oct 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes all the options to tiler (both storage and tiling) to the command line.
I am having an issue with specc'ing the S3 part. It seems as though
Fog.mock!, required for testing, is not registering when called in abeforeand then running the binary. Perhaps the execution of thedztbinary is happening in a different thread?I left the spec pending for now, I did run this from the command line and verify that it worked.