Fixing Dockerfile and refactoring #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2024 12:39
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JJ-Author
requested changes
Jul 2, 2024
| @@ -80,28 +56,28 @@ def get_ontology_from_request(request): | |||
| if v[0].decode('utf-8') == 'Host': | |||
| print('host found') | |||
| host = v[1].decode('utf-8') | |||
| path = request.path.decode('utf-8') | |||
| ontology = 'https://' + host + request.path.decode('utf-8') | |||
There was a problem hiding this comment.
this hardcoded https seems really unsafe to me.
is there really no better way to get the scheme (protocol) - e.g. from the request object or by passing it as parameter?
keep in mind that this empty host seems to be a bug and could be fixed then this would break
also note that path is decoded twice
|
we openend this issue here abhinavsingh/proxy.py#1437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.