Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all: Thanks for creating bongo. I just started to use it and really like it!
I also noticed high CPU load:
#3
and did some profiling/improvements:
High CPU load is produced by parsing mpg123 process output. Instead
of creating a temporary buffer for each process output and using
buffer-search/regex functions to parse it, transform input string to
an intermediate list representation by using faster string functions.
Also remove duplicate events: By rounding the elapsed time to full
seconds a lot of events don't have to be processed.
This reduces CPU load from 60% to 24% on my Core2Duo system.