Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Display the amount of processed data when running tests #570

Open
3 tasks done
uatach opened this issue Apr 4, 2024 · 3 comments
Open
3 tasks done

[Feature] Display the amount of processed data when running tests #570

uatach opened this issue Apr 4, 2024 · 3 comments
Labels
feature:cost-reduction Issues related to measuring and reducing execution cost pkg:dbt-bigquery Issue affects dbt-bigquery type:enhancement New feature request

Comments

@uatach
Copy link

uatach commented Apr 4, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

When executing the run or build command, dbt displays the amount of data processed to create tables, I think it would be nice it also displayed the amount of data processed when running tests

Describe alternatives you've considered

No response

Who will this benefit?

We had a situation that after writing some new models, a chart in a report tracking the amount of processed data in BigQuery showed a very sharp increase... we looked at the output from dbt and found that it was processing a lot of data to create some tables, we fixed that but the amount of data processed still increased more than expected, we learned that we had missed some tests that were scanning a lot of the same data and refactored the tests downstream to other models.

Are you interested in contributing this feature?

Yes but I don't know the codebase, no idea where I would start.

Anything else?

No response

@uatach uatach added type:enhancement New feature request triage:product In Product's queue labels Apr 4, 2024
@dbeatty10
Copy link
Contributor

Thanks for reaching out @uatach !

I'm going to transfer this to the dbt-bigquery repo for further consideration since this is specific to BigQuery.

In the meantime, did you take a look at your target/run_results.json?

According to dbt-labs/dbt-core#2964 and dbt-labs/dbt-bigquery#559, the bytes processed should be available there.

But it seems like your ask is specific to the CLI output like this and you want PASS replaced with something like PASS (1.0 rows, 0 processed):

image

@dbeatty10 dbeatty10 transferred this issue from dbt-labs/dbt-core Apr 4, 2024
@dbeatty10 dbeatty10 added triage:awaiting-response Awaiting a response from the reporter and removed triage:product In Product's queue labels Apr 5, 2024
@uatach
Copy link
Author

uatach commented Apr 6, 2024

In the meantime, did you take a look at your target/run_results.json?
According to dbt-labs/dbt-core#2964 and dbt-labs/dbt-bigquery#559, the bytes processed should be available there.

Yes, indeed they are available there, thanks, didn't know about that.

But it seems like your ask is specific to the CLI output like this and you want PASS replaced with something like PASS (1.0 rows, 0 processed)

Yes, displaying it in the CLI output would be great.

@github-actions github-actions bot added triage:product In Product's queue and removed triage:awaiting-response Awaiting a response from the reporter labels Apr 6, 2024
@elyobo
Copy link

elyobo commented May 30, 2024

Agreed, I asked for this feature back in dbt-labs/dbt-bigquery#14 (comment) and it just occurred to me that it never showed up even though I thought that dbt-labs/dbt-bigquery#559 had added it! Didn't realise it was only in the JSON either.

Edit: JSON is probably better for some of my uses anyway, I have some dodgy CLI parsing somewhere that would be easier and more reliable with the JSON data.

@dbeatty10 dbeatty10 added the feature:cost-reduction Issues related to measuring and reducing execution cost label May 30, 2024
@amychen1776 amychen1776 removed the triage:product In Product's queue label Aug 2, 2024
@mikealfare mikealfare added the pkg:dbt-bigquery Issue affects dbt-bigquery label Jan 14, 2025
@mikealfare mikealfare transferred this issue from dbt-labs/dbt-bigquery Jan 14, 2025
mikealfare pushed a commit that referenced this issue Jan 20, 2025
* Update tox requirement from ~=4.6 to ~=4.7

Updates the requirements on [tox](https://github.com/tox-dev/tox) to permit the latest version.
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](tox-dev/tox@4.6.0...4.7.0)

---
updated-dependencies:
- dependency-name: tox
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add automated changelog yaml from template for bot PR

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Github Build Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:cost-reduction Issues related to measuring and reducing execution cost pkg:dbt-bigquery Issue affects dbt-bigquery type:enhancement New feature request
Projects
None yet
Development

No branches or pull requests

5 participants