updated conversion tests to include child types #93
Conversation
added reference to issue Co-authored-by: Kyle Wigley <[email protected]>
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| ### Under the hood | |||
| - Adding `execution_project` to `target` object ([#66](https://github.com/dbt-labs/dbt-bigquery/issues/66)) | |||
| - Fix test related to preventing coercion of boolean values (True, False) to numeric values (0, 1) in query results ([#93](https://github.com/dbt-labs/dbt-bigquery/issues/93)) | |||
There was a problem hiding this comment.
I think we need to change the section this is in @McKnight-42. Could you open another PR that creates a new section above dbt-bigquery 1.1.0 (Release TBD) and then change the release date for dbt-bigquery 1.0.0 to be December 3, 2021? I think we missed updating this when we did the release
There was a problem hiding this comment.
@leahwicz Do we still want it in the under the hood section of the tbd or placed in fixes?
There was a problem hiding this comment.
Let's start a new Fixes section under 1.1.0 and put this under there
There was a problem hiding this comment.
done, changes made in a new pr #95
|
@McKnight-42 Big belated thanks for this! There's an open PR in Snowflake that fixes the same test. Think you might be able to take a look? dbt-labs/dbt-snowflake#76 I also think we'll need to make the change over in |
* updated conversion tests to include child types * added changelog.md * Update CHANGELOG.md added reference to issue Co-authored-by: Kyle Wigley <[email protected]> Co-authored-by: Kyle Wigley <[email protected]>
dbt-labs#95) * updating changlog, adding tbd for 1.1.0, updating 1.0.0 release date moving dbt-labs#93 * updating changelog to be Fixes section instead of Under the hood
* updated conversion tests to include child types * added changelog.md * Update CHANGELOG.md added reference to issue Co-authored-by: Kyle Wigley <[email protected]> Co-authored-by: Kyle Wigley <[email protected]>
* Pointing the 1.0.latest branch to the Core release branch * updated conversion tests to include child types (#93) * updated conversion tests to include child types * added changelog.md * Update CHANGELOG.md added reference to issue Co-authored-by: Kyle Wigley <[email protected]> Co-authored-by: Kyle Wigley <[email protected]> * Fixing pip update for CI (#196) * Fixing whitespace * Adding missing py39 version from test matrix Co-authored-by: Matthew McKnight <[email protected]> Co-authored-by: Kyle Wigley <[email protected]>
resolves #
Description
co-author: @kwigley
updated test to check for child types, was causing python 3.7 and 3.8 failures
Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.